[PATCH] D67060: [Support] Support restoring colors in WithColor

Seiya Nuta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 3 18:34:10 PDT 2019


seiya added a comment.

In D67060#1655157 <https://reviews.llvm.org/D67060#1655157>, @ruiu wrote:

> Did you find any existing usage of WithColor that depends on the behavior of resetting the color? If not, you don't have to care too much about keeping the compatibility, as that is not really an intended feature as far as I understand. You probably can just change the behavior of WithColor so that it restores to the previous color instead of resseting.


I grep'ed the existing usage and ran tests in `llvm/test/tools` but it looks that no tests relies on the behavior. As you say it's safe to change the behavior I think.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67060/new/

https://reviews.llvm.org/D67060





More information about the llvm-commits mailing list