[PATCH] D66322: [X86] Updated target specific selection dag code to conservatively check for isAtomic in addition to isVolatile

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

In D66322#1656318 <https://reviews.llvm.org/D66322#1656318>, @reames wrote:

> In D66322#1653843 <https://reviews.llvm.org/D66322#1653843>, @RKSimon wrote:
>
> > We have the isSimple() wrapper for  in LoadInst and StoreInst, could we add that to MemSDNode as well?
> >
> >   bool isSimple() const { return !isAtomic() && !isVolatile(); }
> >
>
>
> I thought about it, but it seemed very likely to be confused the isSimple predicate on value types.  I'm happy to add it if you want though.


I don't think it'd be confusing, but if you are uncertain, another method name would be fine.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66322/new/

https://reviews.llvm.org/D66322