[PATCH] D67126: [GVN/FP] Considate logic for reasoning about equality vs equivalance for floats

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added inline comments.


================
Comment at: lib/Transforms/Scalar/GVN.cpp:1429
+      // equivalence. 
+      // FIXME: We should do this optimization if 'no signed zeros' is
+      // applicable via an instruction-level fast-math-flag or some other
----------------
reames wrote:
> xbolva00 wrote:
> > Cmp->getFastMathFlags().noSignedZeros() ?
> a) I just moved the todo
> b) See the comment about not considering myself particularly FP knowledgeable.  
Ok, no problem


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67126/new/

https://reviews.llvm.org/D67126