[PATCH] D63877: Avoid infinite loop with asan interception

Jonas Hahnfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 3 13:34:43 PDT 2019


Hahnfeld added a comment.

In D63877#1656135 <https://reviews.llvm.org/D63877#1656135>, @serge-sans-paille wrote:

> @Hahnfeld : I understand your concern. However this test case is meant to test handling of stdlib exceptions, so it doesn't look strange to disable it if stdlib is not used, right? [...]


I can't follow here: As far as I understand, this test case ensures that asan can handle a runtime which is itself linked against an stdlib that provides `__cxa_throw`. However, exceptions are not used inside asan, and with `SANITIZER_CXX_ABI=libcxxabi` the runtime is not linked against a full C++ stdlib, so there's no `__cxa_throw` in the asan shared library. Is that summary correct?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63877/new/

https://reviews.llvm.org/D63877





More information about the llvm-commits mailing list