[PATCH] D66525: WIP: [llvm-dwarfdump] Add additional stats fields

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Looks mostly good to me!



================
Comment at: llvm/tools/llvm-dwarfdump/Statistics.cpp:54
   unsigned NumVarTypes = 0;
-  /// Number of variables wtih DW_AT_location.
+  /// Number of variables with DW_AT_location.
   unsigned NumVarLocations = 0;
----------------
Feel free to fix these spelling issues in a separate nfc commit right away.


================
Comment at: llvm/tools/llvm-dwarfdump/Statistics.cpp:154
+                            bool IsLocalVar) {
+  unsigned InScopeCovered = 100 * (double)BytesCovered / BytesInScope;
+  if (InScopeCovered == 0) {
----------------
Please define and use a helper function to get the coverage bucket, given BytesCovered & BytesInScope.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66525/new/

https://reviews.llvm.org/D66525