[PATCH] D66526: WIP: [utils] Add the llvm-locstats tool

[Vedant Kumar via Phabricator via llvm-commits]

vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

Thanks, this looks good to me. Perhaps you can get more feedback by dropping the WIP label. @aprantl, any thoughts?



================
Comment at: llvm/utils/llvm-locstats/llvm-locstats.py:175
+    variables_total_locstats = \
+      json_parsed['total variables procesed by location statistics']
+    variables_scope_bytes_covered = \
----------------
djtodoro wrote:
> vsk wrote:
> > What's the difference between this ('total variables procesed by location statistics') and 'total vars procesed by location statistics' above?
> I just followed the existing name convention within `llvm-dwarfdump` statistics. Reporting stats with "`variables"` applies to both local variables and formal parameters, `"vars"` applies only to local variables and `"formal parameters"` obviously applies only to formal parameters.
Ok. Perhaps we can revisit that & pick a clearer naming convention later.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66526/new/

https://reviews.llvm.org/D66526