[PATCH] D66825: [10/10] [LLD] [COFF] Implement MinGW default manifest handling

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 3 12:04:02 PDT 2019


mstorsjo updated this revision to Diff 218510.
mstorsjo marked 3 inline comments as done.
mstorsjo retitled this revision from "[10/10] [LLD] [COFF] Silently drop a manifest with language 0, if there's another manifest with a nonzero language id" to "[10/10] [LLD] [COFF] Implement MinGW default manifest handling".
mstorsjo edited the summary of this revision.
mstorsjo added a comment.

Fixed method naming, made helper const.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66825/new/

https://reviews.llvm.org/D66825

Files:
  lld/COFF/DriverUtils.cpp
  lld/test/COFF/Inputs/manifest-lang0.res
  lld/test/COFF/Inputs/manifest-lang0.yaml
  lld/test/COFF/Inputs/manifest-lang1.res
  lld/test/COFF/Inputs/manifest-lang1.yaml
  lld/test/COFF/Inputs/manifest-lang2.res
  lld/test/COFF/Inputs/manifest-lang2.yaml
  lld/test/COFF/merge-resource-manifest.test
  llvm/include/llvm/Object/WindowsResource.h
  llvm/lib/Object/WindowsResource.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66825.218510.patch
Type: text/x-patch
Size: 13152 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190903/c4156cbf/attachment.bin>


More information about the llvm-commits mailing list