[PATCH] D67089: Skip MCJIT unit tests if LLVM is not configured for native compilation
Sergej Jaskiewicz via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 3 11:48:46 PDT 2019
broadwaylamb marked an inline comment as done.
broadwaylamb added inline comments.
================
Comment at: llvm/unittests/ExecutionEngine/MCJIT/MCJITTestAPICommon.h:58
+ std::string Error;
+ return TargetRegistry::lookupTarget(HostTriple, Error) != 0;
+ }
----------------
dblaikie wrote:
> Please use 'nullptr' rather than '0' for a null pointer constant.
I'm not sure I understand how Phabricator works: does the most recent diff get composed with the older one, or rather replaces it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67089/new/
https://reviews.llvm.org/D67089
More information about the llvm-commits
mailing list