[PATCH] D67121: [TargetLowering] Make allowsMemoryAccess methode virtual.

James Molloy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 3 11:33:18 PDT 2019


jmolloy added a comment.

> Aren't the targets intended to override allowsMisalignedMemoryAccesses? Does that not work for your usage?

Unfortunately not. The target in question does not have byte or word stores. The intent is for the target hook implementation to return false based upon `VT` (a trunc-store doesn't change the alignment of the underlying pointer). I don't myself see a rationale why this function shouldn't be overridable, given that it isn't a no-op wrapper around allowsMisalignedMemoryAccesses.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67121/new/

https://reviews.llvm.org/D67121





More information about the llvm-commits mailing list