[PATCH] D66958: [AMDGPU] Enable constant offset promotion to immediate operand for VMEM stores

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:1326
 
-  // TODO: Support Store.
-  if (!MI.mayLoad())
+  if (MI.mayLoad() && TII->getNamedOperand(MI, AMDGPU::OpName::vdata) != NULL)
     return false;
----------------
nullptr or !TII->getNamedOperand()


================
Comment at: lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:1326
 
-  // TODO: Support Store.
-  if (!MI.mayLoad())
+  if (MI.mayLoad() && TII->getNamedOperand(MI, AMDGPU::OpName::vdata) != NULL)
     return false;
----------------
rampitec wrote:
> nullptr or !TII->getNamedOperand()
Stores also have vdata, aren't they?


================
Comment at: test/CodeGen/AMDGPU/promote-constOffset-to-imm.mir:194
+# GFX9-LABEL: name: diffoporder_add_store
+# GFX9: GLOBAL_STORE_DWORD %{{[0-9]+}}, %0.sub0, 1000, 0, 0, 0
+# GFX9: GLOBAL_STORE_DWORD %{{[0-9]+}}, %0.sub1, 0, 0, 0, 0
----------------
Needs test where stores are actually combined.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66958/new/

https://reviews.llvm.org/D66958