[PATCH] D67101: Target hooks for custom COPY insertion.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 3 11:02:29 PDT 2019


lebedev.ri added a comment.

In D67101#1655973 <https://reviews.llvm.org/D67101#1655973>, @alex-t wrote:

> In D67101#1655941 <https://reviews.llvm.org/D67101#1655941>, @lebedev.ri wrote:
>
> > Would be good to have test coverage either in the same patch or have dependent patch explicitly marked as such.
>
>
> The patch really changes AMDGPU PHI elimination and leaves other targets behavior unaffected.
>  So the test that I will add make sense for AMDGPU only.
>  Is it okay?


Absolutely.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67101/new/

https://reviews.llvm.org/D67101





More information about the llvm-commits mailing list