[PATCH] D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/DebugInfo/X86/sroa-after-inlining.ll:35
+; CHECK: _Z3barv
+; CHECK: %[[NAME:.*]] = call i32 @_Z3foov
+; CHECK: llvm.dbg.value(metadata i32 %[[NAME]], metadata [[METADATA_IDX1:![0-9]+]]
----------------
avl wrote:
> aprantl wrote:
> > RESULT?
> yes. actual IR looks like this : 
> 
> before second SROA :
>  
>   call void @llvm.dbg.declare(metadata %struct.S1* %result, metadata !12, metadata !DIExpression()), !dbg !21
>   %call = call i32 @_Z3foov(), !dbg !21
>   %coerce.dive = getelementptr inbounds %struct.S1, %struct.S1* %result, i64 0, i32 0, !dbg !21
>   store i32 %call, i32* %coerce.dive, align 4, !dbg !21
> 
> after second SROA:
> 
>   %call = call i32 @_Z3foov(), !dbg !21
>   call void @llvm.dbg.value(metadata i32 %call, metadata !12, metadata !DIExpression()), !dbg !22
> 
> 
Sorry for being unclear: I meant to say: "What about renaming `NAME` to `RESULT`, would that make the test easier to read?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64595/new/

https://reviews.llvm.org/D64595