[PATCH] D65751: [LNT] Add support for v2 fmt in test data library

[Chris Matthews via Phabricator via llvm-commits]

cmatthews added inline comments.


================
Comment at: lnt/testing/__init__.py:52
         """
+        assert self.report_version <= 2
+
----------------
thopre wrote:
> thopre wrote:
> > cmatthews wrote:
> > > Could you add a comment or assertion text explaining why this check is needed.
> > Are these comments appropriate?
> Ping?
 assert self.report_version <= 2, "This library only supports v2 and newer."

When someone hits an assertion, it is nice to see the assertion message, instead of having to navigate to the code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65751/new/

https://reviews.llvm.org/D65751