[PATCH] D66977: [GVN] Propagate simple equalities from assumes within the tail of the block

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 3 10:34:29 PDT 2019


reames added a comment.

In D66977#1653969 <https://reviews.llvm.org/D66977#1653969>, @fhahn wrote:

> LGTM, with a few nits/suggestions for comments. Also, it would be great if you could also add a test case with floats.


Landed w/comments applied and one additional fix noticed when writing your requested floating point test case.

It turned out the code I was extending had a bug where it didn't account for the fact that +0.0 compares equal to -0.0.  I went ahead and added a bailout since the none of the existing tests were effected.

The extra bit seemed obvious.  If anyone thinks it warrants re-review, let me know and I'll revert.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66977/new/

https://reviews.llvm.org/D66977





More information about the llvm-commits mailing list