[PATCH] D66967: [Attributor] ValueSimplify Abstract Attribute

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2514
+        // Current value is regarded as Simplified Value.
+        indicateOptimisticFixpoint();
+        return false;
----------------
uenoku wrote:
> jdoerfert wrote:
> > I am unsure. There are more values in the worklist of the genericValueTraversal which we need to visit and which could change things, right?
> As I look at `genericValueTraversal` , `Stripped` is false if associated value is a leaf (then there is no value in the worklist) so I thought it is more convinient to regard this value as `simplifed`. Is this wrong?
You are right. Forget my comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66967/new/

https://reviews.llvm.org/D66967