[PATCH] D67061: [mir-canon][NFCi] Adding opt arg to enable vreg renaming only mode.

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 3 09:41:42 PDT 2019


paquette added inline comments.


================
Comment at: llvm/test/CodeGen/MIR/AArch64/mirCanonIdempotent.mir:11-19
+# CHECK-NAMER: %namedVReg1361:fpr64 = COPY $d1
+# CHECK-NAMER-NEXT: %namedVReg1358:fpr64 = COPY $d0
+# CHECK-NAMER-NEXT: %namedVReg1355:gpr64 = COPY $x1
+# CHECK-NAMER-NEXT: %namedVReg1352:gpr64common = COPY $x0
+# CHECK-NAMER-NEXT: STRXui %namedVReg1352, %stack.1, 0 :: (store 8)
+# CHECK-NAMER-NEXT: STRXui %namedVReg1355, %stack.2, 0 :: (store 8)
+# CHECK-NAMER-NEXT: STRDui %namedVReg1358, %stack.3, 0 :: (store 8)
----------------
I think this should be split out into a separate test as well.

Also, in the separate test, it looks like you can just axe everything beyond the FMOVDi since that's all that's tested anyway.

(Is there any particular reason this test is so long in the first place?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67061/new/

https://reviews.llvm.org/D67061





More information about the llvm-commits mailing list