[PATCH] D66941: [DebugInfo] LiveDebugValues: explicitly terminate overwritten stack locations

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/CodeGen/LiveDebugValues.cpp:797
+                                      MachineFunction *MF, unsigned &Reg) {
+  SmallVector<const MachineMemOperand *, 1> Accesses;
+
----------------
This doesn't appear to be used in the function?


================
Comment at: lib/CodeGen/LiveDebugValues.cpp:881
+        // the open range, and insert an explicit DBG_VALUE $noreg. Reg clobbers
+        // can be detected by DbgEntityHistoryCalculator, but stack writes are
+        // not.
----------------
One last question: Could/should we fix this in DbgEntityHistoryCalculator instead?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66941/new/

https://reviews.llvm.org/D66941