[PATCH] D67004: [DebugInfo] Enable call site parameter debug info for ARM and AArch64

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/Frontend/CompilerInvocation.cpp:784
+           Arch == llvm::Triple::armeb;
+  };
+
----------------
dstenb wrote:
> vsk wrote:
> > This helper would be easier to read as an out-of-line function, imo.
> Or perhaps something like this?
> 
> ```
> const llvm::Triple::ArchType DebugEntryValueArchs[] = {llvm::Triple::x86, [...]};
> 
> llvm::is_contained(DebugEntryValueArchs, Arch)
> ```
> 
I suppose this is fine, but it would be more elegant if we could query the target whether it supports entry values.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67004/new/

https://reviews.llvm.org/D67004