[PATCH] D67102: DWARF: Fix a regression in location list dumping

[Pavel Labath via Phabricator via llvm-commits]

labath created this revision.
labath added reviewers: JDevlieghere, dblaikie, probinson.
Herald added a subscriber: aprantl.
Herald added a project: LLVM.

While fixing the handling of some error cases, r370363 introduced new
problems -- assertion failures due to unchecked errors (my excuse is that a very
early version of that patch used Optional<T> instead of Expected).

This patch adds proper handling of parsing errors encountered when
dumping location lists from inside DWARF DIEs, and adds a bunch of
additional tests.

I reorder the arguments of the location list dumping functions to make
them consistent, and also be able to dump the two kinds of location
lists generically.


Repository:
  rL LLVM

https://reviews.llvm.org/D67102

Files:
  include/llvm/DebugInfo/DWARF/DWARFDebugLoc.h
  lib/DebugInfo/DWARF/DWARFDebugLoc.cpp
  lib/DebugInfo/DWARF/DWARFDie.cpp
  test/DebugInfo/X86/dwarfdump-debug-loc-error-cases2.s
  test/DebugInfo/X86/dwarfdump-debug-loclists-error-cases2.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67102.218459.patch
Type: text/x-patch
Size: 16707 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190903/b6976926/attachment.bin>