[PATCH] D66944: [PowerPC][XCOFF] Verify symbol table in xcoff object files. [NFC]
Sean Fertile via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 3 08:03:43 PDT 2019
sfertile marked an inline comment as done and an inline comment as not done.
sfertile added inline comments.
================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-common.ll:69
+; SYMS-NEXT: Symbol {
+; SYMS-NEXT: Index: 0
+; SYMS-NEXT: Name: a
----------------
sfertile wrote:
> jasonliu wrote:
> > These Index could easily change when we add more functionality into XCOFF object writer. Do we care about making the test case more robust?
> What do you have in mind?
Ok, I found the numeric substitution blocks in the Filecheck docs. I wasn't aware of that before, thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66944/new/
https://reviews.llvm.org/D66944
More information about the llvm-commits
mailing list