[PATCH] D67078: [llvm-readelf] - Allow dumping the dynamic symbols when there is no program headers.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 3 07:47:10 PDT 2019


grimar added inline comments.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:1648
+      // Normally we find the dynamic symbols section location and size using
+      // the information in sections headers. That allows us to dump dynamic
+      // symbols when program headers are absent. This is consistent with GNU
----------------
jhenderson wrote:
> That -> Doing this
I had to rewrite this comment completely because of behavior change...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67078/new/

https://reviews.llvm.org/D67078





More information about the llvm-commits mailing list