[PATCH] D66340: [RISCV] Support NonLazyBind

James Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 3 03:10:15 PDT 2019


jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:2200
+    if (OpFlags == RISCVII::MO_GOT_HI)
+      Callee = getAddr(S, DAG, 0);
+    else
----------------
The `0` should be `false` since `IsLocal` is a `bool`, and ideally `/*IsLocal=*/false` to document what it means.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66340/new/

https://reviews.llvm.org/D66340





More information about the llvm-commits mailing list