[PATCH] D67089: Skip MCJIT unit tests if LLVM is not configured for native compilation

Sergej Jaskiewicz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 3 03:04:20 PDT 2019


broadwaylamb marked an inline comment as done.
broadwaylamb added inline comments.


================
Comment at: llvm/unittests/ExecutionEngine/MCJIT/MCJITTestAPICommon.h:39
   MCJITTestAPICommon()
-    : HostTriple(sys::getDefaultTargetTriple())
   {
----------------
broadwaylamb wrote:
> This was not in the upstream. I tried to fix these tests by changing this line to `sys::getProcessTriple()` and committed it to my local git repo, and now reverted it, so Arcanist has caught this change.
> 
> The upstream uses `sys::getProcessTriple()`, so please ignore this change.
Correction:  I tried to fix these tests by changing this line to `sys::getDefaultTargetTriple()`, and here reverted it back to `sys::getProcessTriple()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67089/new/

https://reviews.llvm.org/D67089





More information about the llvm-commits mailing list