[PATCH] D66295: [ARM] Sink add/mul(shufflevector(insertelement(...), ...), ...) for MVE instruction selection

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

Yeah. This looks good.

We should wait to commit until we have the instructions that make use of it though. I think Oliver is working on a few patterns for VADD, VMUL and VSUB, which would cover the cases here.

Also can you add a couple of tests for sub (on there own), that the first operand is not sunk but the second operand is.



================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:14326
+  if (!match(I->getOperand(Op),
+            m_ShuffleVector(
+                m_InsertElement(m_Undef(), m_Value(), m_ZeroInt()),
----------------
Make sure you run clang-format.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66295/new/

https://reviews.llvm.org/D66295