[PATCH] D67074: [LV] Fix miscompiles by adding non-header PHI nodes to AllowedExit

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope marked 3 inline comments as done.
bjope added a comment.

Thanks for all the feedback. Landed as rL370721 <https://reviews.llvm.org/rL370721>.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp:779
       // Reduction instructions are allowed to have exit users.
       // All other instructions must not have external users.
       if (hasOutsideLoopUser(TheLoop, &I, AllowedExit)) {
----------------
Ayal wrote:
> While we're at it, the above comment deserves updating as well..
Not sure in what way it should be updated (but it seemed unrelated to the fix so I skipped this).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67074/new/

https://reviews.llvm.org/D67074