[PATCH] D67054: [yaml2obj] Make e_phoff and e_phentsize 0 if there are no program headers

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with one suggestion.



================
Comment at: llvm/test/tools/yaml2obj/elf-no-phdrs.yaml:8
+# CHECK: ProgramHeaderOffset: 0x0
+# CHECK: ProgramHeaderEntrySize: 0
+
----------------
Minor thing: it's probably worth adding a `{{$}}` to the end of this line (and optionally the previous line for symmetry). Without it, `ProgramHeaderEntrySize: 0` could match `ProgramHeaderEntrySize: 0x1234` which would obviously be bad.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67054/new/

https://reviews.llvm.org/D67054