[PATCH] D67060: [Support] Add NestableWithColor

Tue Sep 3 00:55:36 PDT 2019

seiya added a comment.

In D67060#1654353 <https://reviews.llvm.org/D67060#1654353>, @jhenderson wrote:

> In D67060#1654259 <https://reviews.llvm.org/D67060#1654259>, @ruiu wrote:
>
> > Instead of adding a new class, do you think you can change the behavior of WithColor so that it restores the original colors instead of resetting it?
>
>
> This would be my preference too, if it's viable. I don't think WithColor has been around that long, so I suspect it may be straightforward to identify existing usage patterns, and I'd be surprised if any expect restoration to default.

I didn't came up with a good idea to add this feature to WithColor with the compatibility with existing usage but @MaskRay's idea looks good to me. I'll try the idea.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67060/new/

https://reviews.llvm.org/D67060