[PATCH] D67039: [ELF] Add a spell corrector for "undefined symbol" diagnostics

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 2 18:31:33 PDT 2019


thakis added a comment.

This is a cool idea, but I'm struggling to come up with a scenario where it's actually useful :)

For this to fire and be a true positive, you'd have to have an incorrect declaration but a correct definition of a function. I can't remember ever running into this – and the compiler seems to be in a better place to print a diagnostic for this case in almost all cases (except for if the TU with the correct definition doesn't happen to see the incorrect declaration).


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67039/new/

https://reviews.llvm.org/D67039





More information about the llvm-commits mailing list