[PATCH] D66050: Improve division estimation of floating points.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 2 06:47:47 PDT 2019


lebedev.ri added a comment.

In D66050#1624955 <https://reviews.llvm.org/D66050#1624955>, @nemanjai wrote:

> 3. b) It might not be a bad idea to add a test to `test-suite` that will do some fast division vs. non-fast division to make sure the accuracy isn't too bad
> 4. We should do some thorough analysis of the accuracy of the algorithm vs. the HW implementation on a wide range of values on a couple of targets (as was suggested above). I know this was done on PPC, so please share those results and try to replicate on another easily available target (such as X86).


I think these two points weren't addressed.
I'd like to see at least some publicly-stated numbers on accuracy,
just so we //all// know this is going in the right direction for all inputs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66050/new/

https://reviews.llvm.org/D66050





More information about the llvm-commits mailing list