[PATCH] D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies

Mon Sep 2 06:14:37 PDT 2019

jmorse updated this revision to Diff 218349.
jmorse added a comment.

This update simplifies & flattens the copy-forwarding logic as suggested. Rather than trying to select the condition where copy-forwarding is valid, instead continue around the loop whenever a precondition isn't met.

This saves us a level of indentation and makes the conditionals much easier to understand.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58238/new/

https://reviews.llvm.org/D58238

Files:
  lib/CodeGen/MachineSink.cpp
  test/DebugInfo/MIR/X86/postra-subreg-sink.mir
  test/DebugInfo/MIR/X86/sink-leaves-undef.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58238.218349.patch
Type: text/x-patch
Size: 8999 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190902/e33501dc/attachment.bin>