[PATCH] D66859: [index-while-buildling] FSUtil

Dmitri Gribenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 2 05:51:23 PDT 2019

Previous message: [llvm] r370652 - [AMDGPU][MC][GFX10] Corrected constant bus limit for 64-bit shift instructions
Next message: [PATCH] D66859: [index-while-buildling] FSUtil
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

gribozavr added a comment.

Sorry for the late addition to the review, but any chance this API could have a unit test? Of course we can't test the automicity, but basic end to end flow on the "happy path" would be nice to test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66859/new/

https://reviews.llvm.org/D66859

Previous message: [llvm] r370652 - [AMDGPU][MC][GFX10] Corrected constant bus limit for 64-bit shift instructions
Next message: [PATCH] D66859: [index-while-buildling] FSUtil
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list