[PATCH] D65813: Partially revert D61491 "AMDGPU: Be explicit about whether the high-word in SI_PC_ADD_REL_OFFSET is 0"

[Connor Abbott via Phabricator via llvm-commits]

cwabbott accepted this revision.
cwabbott added a comment.
This revision is now accepted and ready to land.

FWIW, this LGTM. Maybe it would be a good idea to add more lines to global-constant.ll to test radeonsi (`amdgcn--` at the moment) and radv (`amdgcn-mesa-mesa3d`) under the NOPAL label.

I believe the no-initializer-constant-addrspace.ll test change is because it uses the `external` linkage and a non-PAL OS, so we emit an extra global offset table lookup once the workaround is removed, but that's normal and shouldn't matter for what it's testing. The R600 change is just due to it getting a separate section and also seems fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65813/new/

https://reviews.llvm.org/D65813