[PATCH] D66526: WIP: [utils] Add the llvm-locstats tool

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro marked 2 inline comments as done.
djtodoro added inline comments.


================
Comment at: llvm/utils/llvm-locstats/llvm-locstats.py:7
+#
+
+import os
----------------
vsk wrote:
> I think this either needs '#!/usr/bin/env python3' or 'from __future__ import print_function'.
I see.. Thanks!

The other LLVM python scripts uses the print function from future package, so I will use that as well.


================
Comment at: llvm/utils/llvm-locstats/llvm-locstats.py:175
+    variables_total_locstats = \
+      json_parsed['total variables procesed by location statistics']
+    variables_scope_bytes_covered = \
----------------
vsk wrote:
> What's the difference between this ('total variables procesed by location statistics') and 'total vars procesed by location statistics' above?
I just followed the existing name convention within `llvm-dwarfdump` statistics. Reporting stats with "`variables"` applies to both local variables and formal parameters, `"vars"` applies only to local variables and `"formal parameters"` obviously applies only to formal parameters.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66526/new/

https://reviews.llvm.org/D66526