[PATCH] D67069: [llvm-strings][test] Merge two closely-related tests

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 2 03:27:02 PDT 2019


jhenderson created this revision.
jhenderson added a reviewer: grimar.
Herald added a subscriber: rupprecht.
Herald added a project: LLVM.

This is a follow-up to feedback on D66015 <https://reviews.llvm.org/D66015>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D67069

Files:
  llvm/test/tools/llvm-strings/eof-no-string.test
  llvm/test/tools/llvm-strings/eof.test


Index: llvm/test/tools/llvm-strings/eof.test
===================================================================
--- llvm/test/tools/llvm-strings/eof.test
+++ llvm/test/tools/llvm-strings/eof.test
@@ -1,5 +1,11 @@
 ## Show that llvm-strings prints the last string in the input even if no
 ## unprintable character follows it.
 
-RUN: echo -n abcdefg | llvm-strings - | FileCheck %s
-CHECK: abcdefg
+RUN: echo -n abcdefg | llvm-strings - | FileCheck %s --check-prefix=PRINT
+PRINT: abcdefg
+
+## Show that llvm-strings does not print the last string in the input if it is
+## too short and no unprintable character follows it.
+
+RUN: echo -n abc | llvm-strings - | FileCheck --allow-empty %s --check-prefix=NOPRINT
+NOPRINT-NOT: abc
Index: llvm/test/tools/llvm-strings/eof-no-string.test
===================================================================
--- llvm/test/tools/llvm-strings/eof-no-string.test
+++ /dev/null
@@ -1,5 +0,0 @@
-## Show that llvm-strings does not print the last string in the input if it is
-## too short and no unprintable character follows it.
-
-RUN: echo -n abc | llvm-strings - | FileCheck --allow-empty %s
-CHECK-NOT: abc


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67069.218321.patch
Type: text/x-patch
Size: 1155 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190902/aacac954/attachment.bin>


More information about the llvm-commits mailing list