[PATCH] D65645: [llvm-dlltool] Remove support for implying output name
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 2 03:15:15 PDT 2019
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lib/ToolDrivers/llvm-dlltool/DlltoolDriver.cpp:168-169
- if (writeImportLibrary(Def->OutputFile, Path, Def->Exports, Machine, true))
- return 1;
+ if (!Path.empty())
+ if (writeImportLibrary(Def->OutputFile, Path, Def->Exports, Machine, true))
+ return 1;
----------------
Nit: you can combine these two `if` with `&&`
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65645/new/
https://reviews.llvm.org/D65645
More information about the llvm-commits
mailing list