[PATCH] D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass.

[Alexey Lapshin via Phabricator via llvm-commits]

avl updated this revision to Diff 218287.
avl added a comment.

My apologies for the delay. I was out of the office and I couldn 't finish it sooner.

finally, addressed comments :

1. split patch in two parts:
  - do not lower structures(this patch)
  - do not clone dbg.declare in instcombiner(would create soon).
2. simplified test case.
3. rewrote lower-dbg-declare.ll to not use structure.
4. mark simplify-dbg-declare-load.ll as XFAIL. @rnk would like to remove it  after chromium's build updated.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64595/new/

https://reviews.llvm.org/D64595

Files:
  llvm/lib/Transforms/Utils/Local.cpp
  llvm/test/DebugInfo/X86/sroa-after-inlining.ll
  llvm/test/Transforms/InstCombine/lower-dbg-declare.ll
  llvm/test/Transforms/Util/simplify-dbg-declare-load.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64595.218287.patch
Type: text/x-patch
Size: 23271 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190902/9c685c58/attachment.bin>