[PATCH] D66967: [Attributor] ValueSimplify Abstract Attribute

[Hideto Ueno via Phabricator via llvm-commits]

uenoku marked 5 inline comments as done.
uenoku added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2447
+    // If everyting is clear, reach optimistic fixpoint.
+    return ExistNone ? ChangeStatus::UNCHANGED : indicateOptimisticFixpoint();
+  }
----------------
jdoerfert wrote:
> jdoerfert wrote:
> > Why unchanged? Don't we have to indicate *any* change in the state? (Same below)
> I'm unsure about this. Even if `None` was not observed we could still lose the information if it was assumed, right? I would prefer to be careful also wrt. to future extensions that could break some invariant here.
>I'm unsure about this. Even if None was not observed we could still lose the information if it was assumed, right? 
I agree. I erased them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66967/new/

https://reviews.llvm.org/D66967