[PATCH] D53137: Scalable vector core instruction support + size queries
Diana Picus via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 30 01:28:42 PDT 2019
rovka added a comment.
In D53137#1650774 <https://reviews.llvm.org/D53137#1650774>, @huntergr wrote:
> Does anyone like Sander's suggestion to make `ScalableSize` (or whatever we end up naming it) the return value for all size queries and provide an overloaded cast operator to transparently work with existing code comparing against `unsigned` values? Or is it preferable to keep the current split?
+1 from me, I definitely like Sander's suggestion. I thought we were heading towards ScalableSize-only functions anyway and that this was just a temporary path until we cleaned up the codebase from unsigned. Using a cast operator from the start seems like an even better way of getting there, since that way at least we hopefully won't get that many new uses of unsigned in the interim.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53137/new/
https://reviews.llvm.org/D53137
More information about the llvm-commits
mailing list