[PATCH] D62341: [DAGCombine][X86][AArch64][AMDGPU][MIPS][PPC] (sub x, c) -> (add x, -c) vector edition.

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 28 15:11:51 PDT 2019


hfinkel added a comment.

In D62341#1647808 <https://reviews.llvm.org/D62341#1647808>, @lebedev.ri wrote:

> @hfinkel should i be worried about PPC regressions here?
>  Those are there regardless of the patch (instcombine already did this fold).
>  I'm not yet sure how to handle them, in some of these patterns the constant
>  is already constant-pool load, in some cases it's bitcasted, etc.


Yeah, those don't look good. @nemanjai , are we just missing some patterns?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62341/new/

https://reviews.llvm.org/D62341





More information about the llvm-commits mailing list