[PATCH] D66663: [DebugInfo] LiveDebugValues should always revisit backedges if it skips them

Wed Aug 28 10:12:29 PDT 2019

jmorse added a comment.

In D66663#1647741 <https://reviews.llvm.org/D66663#1647741>, @aprantl wrote:

> This patch looks really elegant. Does the removal of the initialization phase have any adverse effect on the performance?

A few asan-builds of clang-3.4 showed no notable difference in performance at all.

> Which hash is colliding to contribute top the XFAILed test? Should we fix PR43058 before landing this?

I've uploaded D66895 <https://reviews.llvm.org/D66895> to fix this, it wasn't as deep a problem as I feared. I've added it as a child revision to this patch because the regression test I add in D66895 <https://reviews.llvm.org/D66895> depends on transfers in the entry block being considered, which they aren't without this patch.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66663/new/

https://reviews.llvm.org/D66663