[PATCH] D66278: [RISCV] Enable tail call opt for variadic function

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 28 07:03:37 PDT 2019


luismarques added inline comments.


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:1966
 
-  // Do not tail call opt functions with varargs.
-  if (IsVarArg)
----------------
@Jim you say in a review comment that "If the varargs are all passed by registers, it can do tail call opt." but this comment just says that functions with varargs cannot be tail call optimized.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66278/new/

https://reviews.llvm.org/D66278





More information about the llvm-commits mailing list