[PATCH] D66725: [DAGCombiner][TargetLowering] Target hook for FCOPYSIGN arg cast folding

[Sam Elliott via Phabricator via llvm-commits]

lenary added inline comments.
Herald added a subscriber: wuzish.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:2590
+  virtual bool canCopySign(EVT ValueTy, EVT SignTy) const {
+    return isOperationExpand(ISD::FCOPYSIGN, ValueTy) || ValueTy == SignTy;
+  }
----------------
Which targets use this default and not `SignTy != i128`, beyond RISC-V and WebAssembly?


================
Comment at: llvm/test/CodeGen/RISCV/copysign-casts.ll:18
+
+define double @fold_promote(double %a, float %b) {
+; RV32I-ILP32-LABEL: fold_promote:
----------------
NIT: Can you add `noexcept` to these tests?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66725/new/

https://reviews.llvm.org/D66725