[PATCH] D66752: [RISCV] Implement RISCVRegisterInfo::getPointerRegClass

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 27 04:47:36 PDT 2019


lenary accepted this revision.
lenary added a comment.
This revision is now accepted and ready to land.

In D66752#1646805 <https://reviews.llvm.org/D66752#1646805>, @luismarques wrote:

> In D66752#1646711 <https://reviews.llvm.org/D66752#1646711>, @lenary wrote:
>
> > This should be causing an assert everywhere it's used right now, shouldn't it? I'm confused that we're not seeing any of those asserts/failures in our testcases.
>
>
> That's because overall it's not used much, so we were "lucky" not to hit the assert. But your reasoning makes sense.


Ok, cool. I'm happy for this to land without a testcase.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66752/new/

https://reviews.llvm.org/D66752





More information about the llvm-commits mailing list