[PATCH] D66625: [X86] Print register names in .seh_* directives

[Reid Kleckner via Phabricator via llvm-commits]

rnk marked an inline comment as done.
rnk added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3791
+  unsigned Reg = 0;
+  if (parseSEHRegisterNumber(X86::GR64RegClassID, Reg))
+    return true;
----------------
craig.topper wrote:
> Do we need to support 32-bit registers in 32-bit mode? Or is there soemthing about .seh that is only 64-bit?
These directives should be 64-bit only. There are tests for that at `llvm/test/MC/AsmParser/seh-directive-errors.s`. I noticed a crash, I'll fix that in a sec.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66625/new/

https://reviews.llvm.org/D66625