[PATCH] D62908: [PowerPC] Improve float vector gather codegen

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp accepted this revision.
stefanp added a comment.
This revision is now accepted and ready to land.

Overall this looks good. I have a couple of very minor comments that can be fixed on commit. 
LGTM.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:3987
+              (v4f32 (XXPERMDI (XXMRGHW AlignValues.LD32D, AlignValues.LD32C),
+                               (XXMRGHW AlignValues.LD32B, AlignValues.LD32A), 3))>;
     def : Pat<(v4f32 (build_vector f32:$D, f32:$C, f32:$B, f32:$A)),
----------------
nit:
Line length.


================
Comment at: llvm/test/CodeGen/PowerPC/float-vector-gather.ll:4
+; RUN: -ppc-asm-full-reg-names -mtriple=powerpc64le-unknown-linux-gnu < %s \
+; RUN: | FileCheck %s
+define dso_local <4 x float> @vector_gatherf(float* nocapture readonly %a,
----------------
Please add a note at the start here to say what you are testing.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62908/new/

https://reviews.llvm.org/D62908