[PATCH] D66935: [AArch64][DebugInfo] Do not recompute CalleeSavedStackSize

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a subscriber: MatzeB.
efriedma added a comment.

> This method seems to be called by several passes:

PrologEpilogInserter is expected to do this; it needs both the information, and the side-effects which modify the stack layout.  And the call in RegisterScavenging is actually a unit-test which is trying to fake the state computed by PEI. So really, there are three places which are using the API after PrologEpilogInserter.

None of the places that use the API after PEI want any side-effects.  And none of them actually use the functionality to update the RegisterScavenger state.  LiveDebugValues and RegUsageInfoCollector both appear to just be using determineCalleeSaves as a bad substitute for getCalleeSavedInfo.

> one could argue that determineCalleeSaves is still a valid interface to use

It seems much simpler to just say it isn't a valid interface to use after PEI.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66935/new/

https://reviews.llvm.org/D66935