[PATCH] D66909: [GVN] Disallow phi translation for expressions with calls.

Fri Aug 30 10:52:55 PDT 2019

wmi added a comment.

In D66909#1651731 <https://reviews.llvm.org/D66909#1651731>, @asbirlea wrote:

> Thanks Wei, I think the patch you sent looks like a good path forward. I'd have a few comments on it.
>  Do you want to send it for review and pick up the test from this patch? I'll be happy to review it.

Thanks Alina. Send https://reviews.llvm.org/D67013 for review. I found MemDepResult with 'Def' DefType won't give us the collection of calls we want. It will give us the collection of identical calls without clobber between them and the current call, however, the identical criteria is too strict to accommodate phi-translate case.

So currently D67013 <https://reviews.llvm.org/D67013> only does phitranslate for the call instruction with NonFuncLocal type MemDepResult, i.e., no clobber instruction in current function, and it is still conservative.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66909/new/

https://reviews.llvm.org/D66909