[PATCH] D65464: [LoopFusion] Add ability to fuse guarded loops

Kit Barton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 30 10:19:16 PDT 2019


kbarton marked an inline comment as done.
kbarton added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopFuse.cpp:1090
+  /// it can safely move around the loops.
+  bool isEmptyGuardBlock(const FusionCandidate &FC) const {
+    assert(FC.GuardBranch && "Expecting a fusion candidate with guard branch.");
----------------
reames wrote:
> This check is awfully restrictive, and can probably be easily generalized.  I'm expecting that's your intent with future patches, so let's discuss there.
Yes, once the ability to move code from between loops has been added, this restriction can be relaxed or removed altogether. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65464/new/

https://reviews.llvm.org/D65464





More information about the llvm-commits mailing list