[PATCH] D66921: GlobalISel: Add known bits to InstructionSelector

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

In D66921#1652690 <https://reviews.llvm.org/D66921#1652690>, @arsenm wrote:

> > I note that the ARM equivalent of AArch64InstructionSelector doesn't call have the equivalent of setupMF.
>
> That isn't it. InstructionSelector isn't the pass itself (InstructionSelect is), and setupMF has a default implementation


Agreed. I arrived at this patch via bisection. I've done a few more experiments and it seems like it is not just the ARM Global Isel tests that depend on the AArch64 backend. If I build the X86 and AMDGPU targets without AArch64 then some of their Global Isel tests fail aswell. Last bit of naive speculation before I go home. The only place in the codebase  with INITIALIZE_PASS_DEPENDENCY(GISelKnownBitsAnalysis) is in AArch64PreLegalizerCombiner.cpp. Does this need to be added to the other backends that use Global Isel?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66921/new/

https://reviews.llvm.org/D66921