[PATCH] D66526: WIP: [utils] Add the llvm-locstats tool

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 30 09:31:36 PDT 2019


vsk added inline comments.


================
Comment at: llvm/utils/llvm-locstats/llvm-locstats.py:7
+#
+
+import os
----------------
I think this either needs '#!/usr/bin/env python3' or 'from __future__ import print_function'.


================
Comment at: llvm/utils/llvm-locstats/llvm-locstats.py:175
+    variables_total_locstats = \
+      json_parsed['total variables procesed by location statistics']
+    variables_scope_bytes_covered = \
----------------
What's the difference between this ('total variables procesed by location statistics') and 'total vars procesed by location statistics' above?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66526/new/

https://reviews.llvm.org/D66526





More information about the llvm-commits mailing list